Skip to content

[codex] cut aho-corasick 1.0.0 - #53

Merged
jan-kubica merged 3 commits into
mainfrom
codex/stable-1.0.0
Apr 18, 2026
Merged

[codex] cut aho-corasick 1.0.0#53
jan-kubica merged 3 commits into
mainfrom
codex/stable-1.0.0

Conversation

@jan-kubica

@jan-kubica jan-kubica commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps @stll/aho-corasick and @stll/aho-corasick-wasm from 1.0.0-rc.1 to 1.0.0.

Why

This is part of the stable release cut for the Stella text-search engine stack.

Validation

  • node scripts/version-sync.mjs check --tag v1.0.0
  • npm pack --json --ignore-scripts --dry-run
  • cd wasm && npm pack --json --ignore-scripts --dry-run

Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@greptile-apps

greptile-apps Bot commented Apr 18, 2026

Copy link
Copy Markdown

Greptile Summary

This PR promotes @stll/aho-corasick and @stll/aho-corasick-wasm from 1.0.0-rc.1 to 1.0.0 stable across all manifests: Cargo.toml, Cargo.lock, package.json, four platform npm/*/package.json files, wasm/package.json, index.cjs version-check guards, the bun.lock lockfile, and the CycloneDX SBOM. The SBOM inconsistencies flagged in the prior review thread have been resolved — all version, purl, and bom-ref fields in provenance/sbom.cdx.json now consistently reflect 1.0.0.

Confidence Score: 5/5

Safe to merge; the only finding is a P2 noting that bun.lock integrity hashes need regeneration after the packages are published to npm.

All version strings are consistently updated across every manifest, the SBOM is now internally consistent (previous thread concerns resolved), and all native-binding version guards are correct. The sole remaining concern — stale sha512 hashes in bun.lock — is a post-publish housekeeping task that doesn't block correctness before publishing, warranting a full 5/5.

bun.lock — integrity hashes should be regenerated after 1.0.0 packages are published to npm.

Important Files Changed

Filename Overview
bun.lock Version strings updated from 1.0.0-rc.1 to 1.0.0 for all five platform packages, but the sha512 integrity hashes are identical to the rc.1 hashes — stale if packages haven't been published yet.
provenance/sbom.cdx.json All bom-ref, purl, and version fields for both stella-aho-corasick (Cargo) and @stll/aho-corasick (npm) components updated to 1.0.0 — previously flagged inconsistencies resolved.
index.cjs All 20+ platform version-check guards updated from 1.0.0-rc.1 to 1.0.0 consistently.
package.json Root package version and all optionalDependency pinned versions updated to 1.0.0.
Cargo.toml Package version bumped from 1.0.0-rc.1 to 1.0.0.
wasm/package.json WASM package version bumped from 1.0.0-rc.1 to 1.0.0.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["PR: bump 1.0.0-rc.1 to 1.0.0"] --> B["Cargo.toml / Cargo.lock"]
    A --> C["package.json + npm/* + wasm/package.json"]
    A --> D["index.cjs version guards"]
    A --> E["bun.lock"]
    A --> F["provenance/sbom.cdx.json"]

    B --> G["stella-aho-corasick crate 1.0.0 ✓"]
    C --> H["@stll/aho-corasick 1.0.0 + 5 platform packages ✓"]
    D --> I["All 20 platform version checks expect 1.0.0 ✓"]
    E --> J["Version strings updated ✓ — sha512 hashes stale ⚠"]
    F --> K["All bom-ref / purl / version fields 1.0.0 ✓"]
Loading

Reviews (2): Last reviewed commit: "chore: rerun stable CI" | Re-trigger Greptile

Comment thread provenance/sbom.cdx.json
@jan-kubica
jan-kubica merged commit ebb3cd5 into main Apr 18, 2026
22 checks passed
@jan-kubica
jan-kubica deleted the codex/stable-1.0.0 branch April 18, 2026 11:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant